Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve](common) Add synchronized to avoid concurrent modification #42384 #42453

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Oct 25, 2024

cherry pick from #42384

@w41ter
Copy link
Contributor Author

w41ter commented Oct 25, 2024

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@doris-robot
Copy link

TPC-H: Total hot run time: 48965 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2110d5389beff3a81fb618050393bd8a070a75b8, data reload: false

------ Round 1 ----------------------------------
q1	17756	4376	4410	4376
q2	2063	152	145	145
q3	10440	1854	1884	1854
q4	10372	1217	1330	1217
q5	9118	3913	3912	3912
q6	233	124	124	124
q7	2016	1617	1588	1588
q8	9304	2723	2671	2671
q9	10481	10082	9903	9903
q10	8648	3543	3524	3524
q11	421	234	254	234
q12	470	300	308	300
q13	18351	3977	4016	3977
q14	360	338	335	335
q15	513	453	476	453
q16	547	467	464	464
q17	1123	977	930	930
q18	7251	6855	6772	6772
q19	1689	1498	1486	1486
q20	552	321	298	298
q21	4404	4103	4017	4017
q22	497	408	385	385
Total cold run time: 116609 ms
Total hot run time: 48965 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4372	4333	4354	4333
q2	324	227	225	225
q3	4171	4126	4088	4088
q4	2726	2736	2744	2736
q5	7175	7062	7092	7062
q6	239	120	118	118
q7	3246	2812	2840	2812
q8	4352	4470	4459	4459
q9	14248	13861	13732	13732
q10	4233	4225	4243	4225
q11	742	677	703	677
q12	1013	837	872	837
q13	7056	3771	3726	3726
q14	449	438	419	419
q15	497	464	462	462
q16	640	586	582	582
q17	3881	3792	3759	3759
q18	8664	8717	8747	8717
q19	1721	1647	1653	1647
q20	2343	2148	2092	2092
q21	8494	8419	8532	8419
q22	1002	961	918	918
Total cold run time: 81588 ms
Total hot run time: 76045 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 212412 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2110d5389beff3a81fb618050393bd8a070a75b8, data reload: false

query1	1001	404	380	380
query2	6554	2197	1985	1985
query3	6927	200	205	200
query4	23363	21762	21354	21354
query5	19739	6513	6517	6513
query6	291	222	232	222
query7	4331	310	309	309
query8	254	261	243	243
query9	3102	2676	2603	2603
query10	482	314	303	303
query11	15809	15068	15107	15068
query12	124	75	72	72
query13	1024	432	440	432
query14	17826	13543	13457	13457
query15	374	218	229	218
query16	6485	281	264	264
query17	1890	934	921	921
query18	896	319	320	319
query19	218	150	145	145
query20	104	91	97	91
query21	187	101	95	95
query22	5218	5055	4998	4998
query23	34223	33443	33668	33443
query24	7866	6301	6350	6301
query25	530	447	424	424
query26	1268	165	162	162
query27	2367	299	295	295
query28	6043	2248	2213	2213
query29	2845	2735	2562	2562
query30	236	174	168	168
query31	950	715	744	715
query32	74	64	60	60
query33	456	268	260	260
query34	867	466	485	466
query35	1148	974	973	973
query36	1261	1130	1234	1130
query37	169	60	62	60
query38	3068	2908	2911	2908
query39	1383	1329	1343	1329
query40	310	96	93	93
query41	40	39	36	36
query42	94	84	87	84
query43	585	592	580	580
query44	1170	731	731	731
query45	248	232	230	230
query46	1238	958	954	954
query47	1930	1705	1640	1640
query48	504	418	410	410
query49	667	383	384	383
query50	857	566	618	566
query51	4753	4627	4605	4605
query52	100	84	87	84
query53	230	183	188	183
query54	2669	2487	2470	2470
query55	93	78	85	78
query56	241	208	218	208
query57	1227	1145	1191	1145
query58	225	213	210	210
query59	3559	3387	3407	3387
query60	226	200	219	200
query61	101	99	98	98
query62	885	466	463	463
query63	203	181	176	176
query64	3418	1608	1497	1497
query65	3619	3572	3579	3572
query66	773	439	393	393
query67	16082	15416	15568	15416
query68	9290	642	658	642
query69	495	277	261	261
query70	1539	1190	1441	1190
query71	396	307	305	305
query72	6786	5018	4850	4850
query73	751	317	314	314
query74	6308	5861	5824	5824
query75	4847	3686	3642	3642
query76	5058	1135	1208	1135
query77	709	252	270	252
query78	12702	12270	11785	11785
query79	8172	645	642	642
query80	2076	392	403	392
query81	496	233	237	233
query82	1168	106	96	96
query83	178	140	132	132
query84	263	71	70	70
query85	984	320	323	320
query86	337	290	290	290
query87	3251	2996	3007	2996
query88	4573	2306	2302	2302
query89	470	284	301	284
query90	2005	214	219	214
query91	178	127	129	127
query92	60	54	51	51
query93	6085	561	560	560
query94	751	215	210	210
query95	2071	1993	1950	1950
query96	646	319	326	319
query97	6569	6454	6438	6438
query98	224	203	194	194
query99	2955	921	839	839
Total cold run time: 319393 ms
Total hot run time: 212412 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2110d5389beff3a81fb618050393bd8a070a75b8, data reload: false

query1	0.03	0.02	0.03
query2	0.07	0.03	0.03
query3	0.24	0.05	0.05
query4	1.82	0.07	0.07
query5	0.53	0.53	0.51
query6	1.23	0.59	0.61
query7	0.01	0.01	0.01
query8	0.03	0.02	0.02
query9	0.52	0.50	0.49
query10	0.54	0.52	0.55
query11	0.13	0.09	0.09
query12	0.12	0.09	0.09
query13	0.63	0.62	0.61
query14	0.78	0.77	0.78
query15	0.79	0.76	0.75
query16	0.37	0.37	0.36
query17	1.01	1.00	1.02
query18	0.22	0.26	0.25
query19	1.89	1.86	1.85
query20	0.02	0.01	0.00
query21	15.47	0.61	0.54
query22	2.03	2.07	1.68
query23	17.32	0.99	0.81
query24	6.28	0.47	1.57
query25	0.35	0.14	0.04
query26	0.68	0.17	0.16
query27	0.05	0.05	0.04
query28	7.09	0.76	0.72
query29	12.71	2.31	2.31
query30	0.62	0.54	0.53
query31	2.81	0.39	0.38
query32	3.37	0.50	0.50
query33	3.05	3.04	3.06
query34	15.26	4.83	4.83
query35	4.85	4.86	4.85
query36	1.05	1.01	1.02
query37	0.06	0.05	0.05
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.14
query41	0.07	0.02	0.02
query42	0.02	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 104.36 s
Total hot run time: 30.26 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 2110d5389beff3a81fb618050393bd8a070a75b8 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

@w41ter w41ter merged commit ce5e44c into apache:branch-2.0 Oct 25, 2024
22 of 24 checks passed
@w41ter w41ter deleted the pick_42384_to_origin_branch-2.0 branch October 25, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants